xiangfu0 commented on code in PR #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r842542077
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TimestampIndexGranularity.java: ########## @@ -0,0 +1,110 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.table; + +import java.util.Arrays; +import java.util.HashSet; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.commons.lang3.StringUtils; +import org.apache.pinot.spi.data.DateTimeFieldSpec; +import org.apache.pinot.spi.data.DimensionFieldSpec; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.data.MetricFieldSpec; + + +/** + * TimestampIndexGranularity is the enum of different time granularities from MILLIS to YEAR. + */ +public enum TimestampIndexGranularity { + MILLISECOND, SECOND, MINUTE, HOUR, DAY, WEEK, MONTH, QUARTER, YEAR; + + private static Set<String> _validValues = + Arrays.stream(TimestampIndexGranularity.values()).map(v -> v.toString()).collect(Collectors.toSet()); + + public static String getColumnNameWithGranularity(String column, TimestampIndexGranularity granularity) { + return "$" + column + "$" + granularity; + } + + public static String extractColumnNameFromColumnWithGranularity(String columnWithGranularity) { + return StringUtils.split(columnWithGranularity, "$")[0]; + } + + public static TimestampIndexGranularity extractGranularityFromColumnWithGranularity(String columnWithGranularity) { + return TimestampIndexGranularity.valueOf(StringUtils.split(columnWithGranularity, "$")[1]); + } + + public static boolean isValidTimeColumnWithGranularityName(String columnName) { + if (columnName.charAt(0) != '$') { + return false; + } + int secondDollarPos = columnName.indexOf('$', 1); + if (secondDollarPos < 0) { + return false; + } + return isValidTimeGranularity(columnName.substring(secondDollarPos + 1)); + } + + public static boolean isValidTimeGranularity(String granularity) { + return _validValues.contains(granularity.toUpperCase()); + } + + public static Set<String> extractTimestampIndexGranularityColumnNames(TableConfig tableConfig) { + // Extract Timestamp granularity columns + Set<String> timeColumnWithGranularity = new HashSet<>(); + if (tableConfig == null || tableConfig.getFieldConfigList() == null) { + return timeColumnWithGranularity; + } + for (FieldConfig fieldConfig : tableConfig.getFieldConfigList()) { + TimestampConfig timestampConfig = fieldConfig.getTimestampConfig(); + if (timestampConfig == null || timestampConfig.getGranularities() == null) { + continue; + } + String timeColumn = fieldConfig.getName(); + for (TimestampIndexGranularity granularity : timestampConfig.getGranularities()) { + timeColumnWithGranularity.add(getColumnNameWithGranularity(timeColumn, granularity)); + } + } + return timeColumnWithGranularity; + } + + /** + * Generate the time column with granularity FieldSpec from existing time column FieldSpec and granularity. + * The new FieldSpec keeps same FieldType, only update the field name. + * + * @param fieldSpec + * @param granularity + * @return time column with granularity FieldSpec, null if FieldSpec is not Dimension/Metric/DateTime type. + */ + public static FieldSpec getFieldSpecForTimestampColumnWithGranularity(FieldSpec fieldSpec, + TimestampIndexGranularity granularity) { + String columnName = fieldSpec.getName(); + if (fieldSpec instanceof DateTimeFieldSpec) { + DateTimeFieldSpec dateTimeFieldSpec = (DateTimeFieldSpec) fieldSpec; + return new DateTimeFieldSpec(TimestampIndexGranularity.getColumnNameWithGranularity(columnName, granularity), + FieldSpec.DataType.TIMESTAMP, dateTimeFieldSpec.getFormat(), dateTimeFieldSpec.getGranularity()); + } + if (fieldSpec instanceof DimensionFieldSpec) { Review Comment: make sense, only check `fieldSpec instanceof DateTimeFieldSpec` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
