siddharthteotia commented on code in PR #8398: URL: https://github.com/apache/pinot/pull/8398#discussion_r842451793
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java: ########## @@ -53,6 +53,8 @@ private SegmentPartitionConfig _segmentPartitionConfig; private boolean _aggregateMetrics; private boolean _nullHandlingEnabled; + private boolean _optimizeDictionaryEnabled; + private double _thresholdMinPercentDictionaryStorageSaved; Review Comment: Just confirming - we are not changing the default behavior (dictionary on all columns) yet right ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
