kmozaid commented on pull request #8255:
URL: https://github.com/apache/pinot/pull/8255#issuecomment-1086786555


   There are three other places where multicolumn partitioning config is not 
allowed.
   
   1. `PinotLLCRealtimeSegmentManager.getPartitionMetadataFromTableConfig:710`
   2. `LLRealtimeSegmentDataManager.setPartitionParameters:1425`
   3. 
`PinotHadoopJobLauncher:HadoopSegmentPreprocessingJob.fetchPartitioningConfig:153`
   
   This feature is NOT support by REALTIME tables so first 2 checks are still 
valid. The last one is specific to Hadoop pre processing job, I think we can 
skip for this feature as we don't really support `BoundedColumnValue` 
partitioner for hadoop;s job 
(https://github.com/apache/pinot/blob/master/pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/partitioners/PartitionFunctionFactory.java#L78).
 It is also deprecated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to