Jackie-Jiang commented on a change in pull request #8445:
URL: https://github.com/apache/pinot/pull/8445#discussion_r840102621
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableSizeReader.java
##########
@@ -99,6 +99,13 @@ public TableSizeDetails getTableSizeDetails(@Nonnull String
tableName, @Nonnegat
_controllerMetrics.setValueOfTableGauge(realtimeTableName,
ControllerGauge.TABLE_SIZE_PER_REPLICA_ON_SERVER,
tableSizeDetails._realtimeSegments._estimatedSizeInBytes /
_helixResourceManager.getNumReplicas(
realtimeTableConfig));
+
+ tableSizeDetails._realtimeSegments._segments.values().stream()
Review comment:
(optional) Suggest using the regular non-stream APIs for the following
reasons:
1. This is indeed more compact, but slightly hard to read
2. It has worse performance comparing to regular APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
