[GitHub] [pinot] jackjlli commented on a change in pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

[GitBox]

jackjlli commented on a change in pull request #8441:
URL: https://github.com/apache/pinot/pull/8441#discussion_r839893027



##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java
##########
@@ -58,25 +60,37 @@
 @JsonIgnoreProperties(ignoreUnknown = true)
 public class InstancePartitions {
   private static final char PARTITION_REPLICA_GROUP_SEPARATOR = '_';
+  private static final String PARTITIONS_KEY = "partitions";
+  private static final String INSTANCE_SEPARATOR = "/";
 
   private final String _instancePartitionsName;
-  private final Map<String, List<String>> _partitionToInstancesMap;
+  private final Map<String, List<String>> 
_partitionWithReplicaGroupToInstancesMap;
+  private final Map<Integer, List<String>> _partitionToInstancesMap;
   private int _numPartitions;
   private int _numReplicaGroups;
 
   public InstancePartitions(String instancePartitionsName) {
     _instancePartitionsName = instancePartitionsName;
+    _partitionWithReplicaGroupToInstancesMap = new TreeMap<>();
     _partitionToInstancesMap = new TreeMap<>();
   }
 
   @JsonCreator
   private InstancePartitions(
       @JsonProperty(value = "instancePartitionsName", required = true) String 
instancePartitionsName,
-      @JsonProperty(value = "partitionToInstancesMap", required = true)
-          Map<String, List<String>> partitionToInstancesMap) {
+      @JsonProperty(value = "partitionWithReplicaGroupToInstancesMap", 
required = true)
+          Map<String, List<String>> partitionWithReplicaGroupToInstancesMap,
+      @JsonProperty(value = "partitionToInstancesMap")

Review comment:
       An example is added to the description of the current PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org