jtao15 commented on a change in pull request #8422:
URL: https://github.com/apache/pinot/pull/8422#discussion_r839131605



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1757,6 +1758,16 @@ public void deleteOfflineTable(String tableName) {
     HelixHelper.removeResourceFromBrokerIdealState(_helixZkManager, 
offlineTableName);
     LOGGER.info("Deleting table {}: Removed from broker resource", 
offlineTableName);
 
+    // Drop the table on servers
+    // TODO: Wait for externalview to converge on controllers instead of 
servers. This is because if externalview

Review comment:
       Added




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to