siddharthteotia commented on a change in pull request #8441:
URL: https://github.com/apache/pinot/pull/8441#discussion_r839047121
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java
##########
@@ -75,9 +94,26 @@ public InstancePartitions
assignInstances(InstancePartitionsType instancePartiti
InstanceReplicaGroupPartitionSelector replicaPartitionSelector =
new
InstanceReplicaGroupPartitionSelector(assignmentConfig.getReplicaGroupPartitionConfig(),
tableNameWithType);
- InstancePartitions instancePartitions = new InstancePartitions(
-
instancePartitionsType.getInstancePartitionsName(TableNameBuilder.extractRawTableName(tableNameWithType)));
replicaPartitionSelector.selectInstances(poolToInstanceConfigsMap,
instancePartitions);
return instancePartitions;
}
+
+ private Map<Integer, List<String>>
extractInstanceNamesFromPoolToInstanceConfigsMap(
+ Map<Integer, List<InstanceConfig>> poolToInstanceConfigsMap) {
+ Map<Integer, List<String>> partitionToInstancesMap = new TreeMap<>();
+ for (Map.Entry<Integer, List<InstanceConfig>> entry :
poolToInstanceConfigsMap.entrySet()) {
+ Integer pool = entry.getKey();
+ List<InstanceConfig> instanceConfigs = entry.getValue();
+ partitionToInstancesMap.put(pool,
extractInstanceNamesFromInstanceConfigs(instanceConfigs));
Review comment:
This is confusing -- poolID is not the same as partitionID
It is `partitionToInstancesMap` but you are using the key as `pool`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
