richardstartin commented on a change in pull request #8408:
URL: https://github.com/apache/pinot/pull/8408#discussion_r837726019
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/query/NonScanBasedAggregationOperator.java
##########
@@ -122,8 +131,26 @@ protected IntermediateResultsBlock getNextBlock() {
return new IntermediateResultsBlock(_aggregationFunctions,
aggregationResults, false);
}
- private double toDouble(Comparable value) {
- if (value instanceof Number) {
+ private static Double getMinValue(DataSource dataSource) {
+ Dictionary dictionary = dataSource.getDictionary();
+ if (dictionary != null) {
+ return toDouble(dictionary.getMinVal());
+ }
+ return toDouble(dataSource.getDataSourceMetadata().getMinValue());
Review comment:
It's only going to be called once per query in this context. There could
be many aggregation functions but I'm tempted to keep things the way they are
for the sake of simplicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
