amrishlal opened a new pull request #8426: URL: https://github.com/apache/pinot/pull/8426
## Description This PR adds support for type conversion from avro complex types (MAP, ARRAY, RECORD, UNION) to Pinot JSON column. Currently, only avro type STRING conversion to JSON column is supported. Ingestion of complex types into JSON column can also be done using Ingestion Transform Function; however, this creates issues for us as the Pinot column name can't be of the same name as the input avro field name.) The main changes, that allows for ingesting complex types into JSON, is in `DataTypeTransformer.java` and `AvroSchemaUtil.java`. `PinotDataType.java` contains a bug fix (the fact that a simple string is also a valid json string) which allows for proper conversion of STRING field to JSON column. `AvroIngestionSchemaValidator` was modified to make sure that we no longer reject avro complex type (MAP, ARRAY, RECORD, UNION) field if they are being ingested into JSON column. The rest of the files (`PinotDataTypeTest.java`, `JsonIngestionFromAvroQueriesTest.java`, `AvroRecordExtractorTest.java`, and `AbstractRecordExtractorTest.java`) contain test cases to validate ingestion of avro complex types into JSON column. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
