Jackie-Jiang commented on a change in pull request #8422:
URL: https://github.com/apache/pinot/pull/8422#discussion_r836730319
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/SegmentDataManager.java
##########
@@ -25,9 +25,16 @@
/**
* Base segment data manager to maintain reference count for the segment.
*/
-public abstract class SegmentDataManager {
+public class SegmentDataManager {
Review comment:
Please add a singleton `DummySegmentDataManager` class instead of
reusing the same class. We should keep this class abstract
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
