noon-stripe commented on a change in pull request #8369:
URL: https://github.com/apache/pinot/pull/8369#discussion_r832562481
##########
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/config/table/IndexingConfigTest.java
##########
@@ -38,6 +38,12 @@ public void testSerDe()
IndexingConfig indexingConfig = new IndexingConfig();
indexingConfig.setLoadMode("MMAP");
indexingConfig.setAggregateMetrics(true);
+ List<PreAggregationConfig> preAggregationConfigs =
+ Arrays.asList(
+ new PreAggregationConfig("c1", "SUM", "SUM_c1"),
+ new PreAggregationConfig("c2", "MIN", "MIN_c2"),
+ new PreAggregationConfig("c3", "MAX", "MAX_c2"));
Review comment:
Also, this test is just a serialization/deserialization test so just a
string is actually needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
