mneedham commented on a change in pull request #8337:
URL: https://github.com/apache/pinot/pull/8337#discussion_r828959948
##########
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java
##########
@@ -290,4 +292,11 @@ private void submitSegmentGenTask(File localTempDir, URI
inputFileURI, int seqId
}
});
}
+
+ private File createLocalInputDateFile(URI inputFileURI, File
localInputTempDir) {
+ String inputFileURIPath = inputFileURI.getPath();
+ String fileNameFriendlyPath = UUID.randomUUID().toString();
+ File localInputFileDir = new File(localInputTempDir, fileNameFriendlyPath);
Review comment:
We need `localInputFileDir` to be a variable as it gets deleted in the
`finally {}` block I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
