siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r828816105
########## File path: pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java ########## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.catalog; + +import java.util.Collection; +import java.util.Collections; +import java.util.Set; +import org.apache.calcite.linq4j.tree.Expression; +import org.apache.calcite.rel.type.RelProtoDataType; +import org.apache.calcite.schema.Function; +import org.apache.calcite.schema.Schema; +import org.apache.calcite.schema.SchemaPlus; +import org.apache.calcite.schema.SchemaVersion; +import org.apache.calcite.schema.Table; +import org.apache.pinot.common.config.provider.TableCache; +import org.apache.pinot.spi.utils.builder.TableNameBuilder; + + +/** + * Simple Catalog that only contains list of tables. Backed by {@link TableCache}. + * + * <p>Catalog is needed for utilizing Apache Calcite's validator, which requires a root schema to store the + * entire catalog. In Pinot, since we don't have nested sub-catalog concept, we just return a flat list of schemas. + */ +public class PinotCatalog implements Schema { + + private final TableCache _tableCache; + + public PinotCatalog(TableCache tableCache) { + _tableCache = tableCache; + } + + @Override + public Table getTable(String name) { + String tableName = TableNameBuilder.extractRawTableName(name); + return new PinotTable(_tableCache.getSchema(tableName)); + } + + @Override + public Set<String> getTableNames() { + return _tableCache.getTableNameMap().keySet(); + } + + @Override + public RelProtoDataType getType(String name) { + return null; + } + + @Override + public Set<String> getTypeNames() { + return Collections.emptySet(); + } + + @Override + public Collection<Function> getFunctions(String name) { + return Collections.emptyList(); + } + + @Override + public Set<String> getFunctionNames() { + return Collections.emptySet(); + } + + @Override + public Schema getSubSchema(String name) { + return null; + } + + @Override + public Set<String> getSubSchemaNames() { + return Collections.emptySet(); + } + + @Override + public Expression getExpression(SchemaPlus parentSchema, String name) { + return null; Review comment: Should we throw `UnsupportedOperationException` / `IllegalStateException` with a proper message instead of returning null in these unused functions ? Is calcite code going to call back into our implementation ? Proper exception might be better than NPE in such case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
