mcvsubbu commented on pull request #8358: URL: https://github.com/apache/pinot/pull/8358#issuecomment-1069748616
> @mcvsubbu segment size can be very useful debugging info (we keep total docs in segment metadata for similar purpose). Currently we only have APIs to read segment size on the servers (uncompressed + extra indexes), but no APIs to read the compressed segment size. The overhead of adding one entry into the segment metadata should be minimal I agree that one extra item is minimal in overhead. We add one at a time, though, and we need to be aware that we are expanding it. It is good to know the use case. If this is only for debugging purpose, we can always query the store to find the (compressed) size of the segment. I don't see the need for adding a metric in that case. Am I missing anything? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
