siddharthteotia commented on a change in pull request #8340: URL: https://github.com/apache/pinot/pull/8340#discussion_r828450641
########## File path: pinot-query-planner/src/main/java/org/apache/calcite/jdbc/CalciteSchemaBuilder.java ########## @@ -0,0 +1,45 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.calcite.jdbc; + +import org.apache.calcite.schema.Schema; + + +/** + * This class is used to create a {@link CalciteSchema} with a given {@link Schema} as the root. + * + * <p>This class resides in calcite.jdbc namespace because there's no complex logic we have in terms of catalog-based + * schema construct. We instead create a {@link SimpleCalciteSchema} that's package protected. + */ +public class CalciteSchemaBuilder { Review comment: Can you add some notes / javadoc on why we need to create a wrapper CalciteSchema on top of another Calcite schema object ? From the [design doc](https://docs.google.com/document/d/1Vbc4MRFzkeGKaYxvVctYUlj9f1P7DfzmoyrNnFIUnmE/edit#), I understand why we need this to interface with Calcite concept of catalog/schema but shouldn't Pinot native Schema be plugged into this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
