KKcorps commented on a change in pull request #8333:
URL: https://github.com/apache/pinot/pull/8333#discussion_r825688295
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StreamGitHubEventsCommand.java
##########
@@ -36,10 +38,21 @@
@CommandLine.Option(names = {"-personalAccessToken"}, required = true,
description = "GitHub personal access token.")
private String _personalAccessToken;
+ @CommandLine.Option(names = {"-sourceType"}, defaultValue = "Kafka",
+ description = "Stream DataSource to use for ingesting data. Supported
values - Kafka,Kinesis")
+ private String _sourceType;
+
@CommandLine.Option(names = {"-kafkaBrokerList"},
description = "Kafka broker list of the kafka cluster to produce
events.")
private String _kafkaBrokerList = KafkaStarterUtils.DEFAULT_KAFKA_BROKER;
+ @CommandLine.Option(names = {"-kinesisEndpoint"},
Review comment:
Those should not be provided as part of properties. The
DefaultCredentialsProvider just picks them up from Env variables or
~/.aws/credentials file. It is a set standard by AWS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
