richardstartin commented on a change in pull request #8343:
URL: https://github.com/apache/pinot/pull/8343#discussion_r825320648
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/IndexCreationContext.java
##########
@@ -393,25 +436,19 @@ public H3IndexConfig getH3IndexConfig() {
}
class Range extends Wrapper {
-
- private final Comparable<?> _min;
- private final Comparable<?> _max;
private final int _rangeIndexVersion;
-
- Range(IndexCreationContext delegate, int rangeIndexVersion, Comparable<?>
min, Comparable<?> max) {
+ Range(IndexCreationContext delegate, int rangeIndexVersion) {
super(delegate);
_rangeIndexVersion = rangeIndexVersion;
- _min = min;
- _max = max;
}
public Comparable<?> getMin() {
- return _min;
+ return getMinValue();
Review comment:
This is an evolving interface (added recently, never tried to replace a
range index yet) so you could just change the method name here i.e. just remove
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
