Jackie-Jiang commented on pull request #8029: URL: https://github.com/apache/pinot/pull/8029#issuecomment-1063318916
Discussed offline. We can simplify the logic by handling the whole gapfill processing on the broker side in the `BrokerRequestHandler`: 1. When getting a gapfill query, rewrite it to the regular non-gapfill query (if the leaf subquery is gap-fill query, trim off the gap-fill part and select all the required columns) 2. Send the non-gapfill query as regular query 3. After reducing the server responses to `BrokerResponse`, apply gapfill to the `ResultTable` within the `BrokerResponse` and set the new `ResultTable` With this logic, all the gapfill handling logic are handled at broker side in the same place without introducing unnecessary overhead to the server -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
