npawar commented on a change in pull request #8274: URL: https://github.com/apache/pinot/pull/8274#discussion_r820308280
########## File path: pinot-plugins/pinot-stream-ingestion/pinot-rocketmq/pom.xml ########## @@ -0,0 +1,77 @@ +<?xml version="1.0"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <artifactId>pinot-stream-ingestion</artifactId> + <groupId>org.apache.pinot</groupId> + <version>0.10.0-SNAPSHOT</version> + <relativePath>..</relativePath> + </parent> + + <artifactId>pinot-rocketmq</artifactId> + <name>Pinot Kinesis</name> Review comment: change name to Pinot RocketMQ ########## File path: pinot-plugins/pinot-stream-ingestion/pinot-rocketmq/src/main/java/org/apache/pinot/plugin/stream/rocketmq/RocketMQConsumerFactory.java ########## @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.stream.rocketmq; + +import java.util.Set; +import org.apache.pinot.spi.stream.PartitionLevelConsumer; +import org.apache.pinot.spi.stream.StreamConsumerFactory; +import org.apache.pinot.spi.stream.StreamLevelConsumer; +import org.apache.pinot.spi.stream.StreamMetadataProvider; + + +/** + * A {@link StreamConsumerFactory} implementation for the RocketMQ stream + */ +public class RocketMQConsumerFactory extends StreamConsumerFactory { + @Override + public PartitionLevelConsumer createPartitionLevelConsumer(String clientId, int partition) { + throw new UnsupportedOperationException(); + } + + @Override + public StreamLevelConsumer createStreamLevelConsumer(String clientId, String tableName, Set<String> fieldsToRead, + String groupId) { + return new RocketMQStreamLevelConsumer(clientId, tableName, _streamConfig, fieldsToRead, groupId); Review comment: high level consumer is deprecated.. is there no concept of partitions in RocketMQ? or an API with partition like semantics? ########## File path: pinot-integration-tests/src/test/resources/rocketmq/airlineStats_data_reduced.schema ########## @@ -0,0 +1,32 @@ +{ + "dimensionFieldSpecs": [ + { + "dataType": "INT", + "singleValueField": true, + "name": "Quarter" + }, + { + "dataType": "STRING", + "singleValueField": true, + "name": "Origin" + }, + { + "dataType": "STRING", + "singleValueField": true, + "name": "Destination" + }, + { + "dataType": "INT", + "singleValueField": true, + "name": "FlightNum" + } + ], + "timeFieldSpec": { Review comment: use dateTimeFieldSpec, as timeFieldSpec is deprecated. Folks often look at integration tests and quickstarts to copy configs, and we don't want anyone using this anymore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
