dongxiaoman commented on a change in pull request #8272:
URL: https://github.com/apache/pinot/pull/8272#discussion_r817982059
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/StreamingReduceService.java
##########
@@ -127,23 +129,19 @@ private static void
processIterativeServerResponse(StreamingReducer reducer, Exe
aggregator.aggregate(entry.getKey(), dataTable);
}
}
+ return null;
Review comment:
Yes good point. I think it was originally something with throwing
Exceptions while `ExecutorService.submit` is called, and the Future<Void> asks
for a return value (at least in my IDE it is red).
Anyway, changed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
