dongxiaoman opened a new pull request #8272: URL: https://github.com/apache/pinot/pull/8272
## Description <!-- Add a description of your PR here. A good description should include pointers to an issue or design document, etc. --> In our `GrpcBrokerRequestHandler` if there is an exception in gRPC calls, the exceptions are suppressed and there is no trace or error handling. The handler will consider all calls "success". This is because gRPC calls are done inside ExecutorService, mostly via a ThreadPool. The Exceptions thrown inside a thread will "stay" inside that thread; when the Future.get() of that thread is called, the Exception will trigger an `ExecutionException` with the thread exception as cause. In our code because we use CountDownLatch to help parallelize the gRPC call, we did not call the Future.get() to trigger the exception. ## Fix Following https://stackoverflow.com/questions/19348248/waiting-on-a-list-of-future we rewrite to use the `ExecutorCompletionService<T>` to help out. ** We may need to look everywhere for CountDownLatch for potential similar problems** ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? No ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> Fixed a bug where `GrpcBrokerRequestHandler` will ignore all gRPC exceptions. <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
