walterddr commented on a change in pull request #8233:
URL: https://github.com/apache/pinot/pull/8233#discussion_r815377380
##########
File path:
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/http/HttpClient.java
##########
@@ -0,0 +1,130 @@
+/**
Review comment:
yes, but it is not related to the flink connector.
for the sake of this PR's scope. i would suggest we drop it and add in
separate PR.
mainly for the following reasons.
- it doesn't relate to flink connector, at first I thought we are utilizing
http to directly ingest into pinot via some sort of REST API. but if it is not
the case it shouldn't be part of flink-pinot connector but rather in
pinot-tools.
- @xiangfu0 also think we can refactor this part out later. doesn't make
sense to get this in an refactor it out if it is not part of the critical path
- there's already one util in test call ControllerUtils that can be used for
demonstration purpose.
Not saying it is not useful, but it would be much easier to address it
separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
