xiangfu0 commented on a change in pull request #8248:
URL: https://github.com/apache/pinot/pull/8248#discussion_r814409355



##########
File path: 
pinot-spi/src/main/java/org/apache/pinot/spi/annotations/ScalarFunction.java
##########
@@ -46,5 +46,10 @@
 
   boolean enabled() default true;
 
-  String name() default "";
+  // A comma-separated function names to register in FunctionRegistry
+  String names() default "";

Review comment:
       There is no usage of this `name()`, but could be usage from pinot users.
   
   I can add it back and mark deprecated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to