mayankshriv commented on a change in pull request #8244:
URL: https://github.com/apache/pinot/pull/8244#discussion_r813491903
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/RecordReaderUtils.java
##########
@@ -50,7 +49,7 @@ public static BufferedInputStream getBufferedInputStream(File
dataFile)
public static InputStream getInputStream(File dataFile)
throws IOException {
- if (dataFile.getName().endsWith(GZIP_FILE_EXTENSION)) {
+ if (GzipUtils.isGZipped(dataFile)) {
Review comment:
The suggestion seems to rely on exception being thrown as part of logic
to determine if this is a Gzipped file or not, which doesn't seem like the best
idea to me. Also, could you elaborate on what is the issue with checking magic
header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
