amrishlal commented on pull request #8243:
URL: https://github.com/apache/pinot/pull/8243#issuecomment-1049364469


   > High level question: how do JSON index, jsonextractscalar or any of the 
other features associated with JSON columns work with this feature?
   
   This PR doesn't effect JSON index, jsonextractscalar, or any of the json 
querying features in any way. All we are doing here is ensuring that we 
recognize avro complex types (which currently throws an error message) for 
ingestion into a JSON column.
   
   > Please submit a design document for what you want to achieve so it can be 
reviewed.
   
   If one ignores the test file, the actual change here is less than 10 lines 
of code with this piece being the most important:
   ```
         case MAP:
         case ARRAY:
         case RECORD:
         case UNION:
           return DataType.JSON;
   ```
   Basically, what we are saying is that if you have a complex type in your 
avro file, we will allow for ingesting that field into a JSON column.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to