walterddr commented on a change in pull request #8176: URL: https://github.com/apache/pinot/pull/8176#discussion_r809585604
########## File path: pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/retention/RetentionManagerTest.java ########## @@ -197,6 +200,15 @@ public Object answer(InvocationOnMock invocationOnMock) return null; } }).when(resourceManager).deleteSegments(anyString(), ArgumentMatchers.anyList()); + + // fake segment lineage. + SegmentLineage segmentLineage = new SegmentLineage(REALTIME_TABLE_NAME); Review comment: good catch not anymore since we fake the segment deletion manager. forgot to clean up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org