weixiangsun commented on a change in pull request #8029:
URL: https://github.com/apache/pinot/pull/8029#discussion_r808721015
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java
##########
@@ -31,7 +36,25 @@
*/
public class GapfillUtils {
private static final String POST_AGGREGATE_GAP_FILL = "postaggregategapfill";
+ private static final String GAP_FILL = "gapfill";
private static final String FILL = "fill";
+ private static final String TIME_SERIES_ON = "timeSeriesOn";
+ private static final int
STARTING_INDEX_OF_OPTIONAL_ARGS_FOR_PRE_AGGREGATE_GAP_FILL = 5;
+
+ public enum GapfillType {
+ // one sql query with gapfill only
+ Gapfill,
+ // gapfill as subquery, the outer query may have the filter
+ GapfillSelect,
+ // gapfill as subquery, the outer query has the aggregation
+ GapfillAggregate,
+ // aggregation as subqery, the outer query is gapfill
+ AggregateGapfill,
+ // aggegration as second nesting subquery, gapfill as fist nesting
subquery, different aggregation as outer query
+ AggregateGapfillAggregate,
+ // no gapfill at all.
+ None
Review comment:
DONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
