snleee commented on a change in pull request #8166:
URL: https://github.com/apache/pinot/pull/8166#discussion_r804255108
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -3078,6 +3078,24 @@ public void revertReplaceSegments(String
tableNameWithType, String segmentLineag
throw new RuntimeException(errorMsg);
}
+ // We do not allow to revert the lineage entry which segments in
'segmentsTo' appear in 'segmentsFrom' of other
Review comment:
I think that we are making the assumption that the snapshots can be at
most 2. Let's add `TODO` comment here that we need to expand this logic when we
support N snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
