weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r803194033
########## File path: pinot-core/src/test/java/org/apache/pinot/queries/PreAggregationGapfillQueriesTest.java ########## @@ -0,0 +1,3088 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.queries; + +import java.io.File; +import java.io.IOException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import org.apache.commons.io.FileUtils; +import org.apache.pinot.common.response.broker.BrokerResponseNative; +import org.apache.pinot.common.response.broker.ResultTable; +import org.apache.pinot.segment.local.indexsegment.immutable.ImmutableSegmentLoader; +import org.apache.pinot.segment.local.segment.creator.impl.SegmentIndexCreationDriverImpl; +import org.apache.pinot.segment.local.segment.readers.GenericRowRecordReader; +import org.apache.pinot.segment.spi.ImmutableSegment; +import org.apache.pinot.segment.spi.IndexSegment; +import org.apache.pinot.segment.spi.creator.SegmentGeneratorConfig; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.data.DateTimeFormatSpec; +import org.apache.pinot.spi.data.DateTimeGranularitySpec; +import org.apache.pinot.spi.data.FieldSpec.DataType; +import org.apache.pinot.spi.data.Schema; +import org.apache.pinot.spi.data.readers.GenericRow; +import org.apache.pinot.spi.utils.ReadMode; +import org.apache.pinot.spi.utils.builder.TableConfigBuilder; +import org.testng.Assert; +import org.testng.annotations.AfterClass; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + + +/** + * Queries test for Gapfill queries. + */ +@SuppressWarnings("rawtypes") +public class PreAggregationGapfillQueriesTest extends BaseQueriesTest { + private static final File INDEX_DIR = new File(FileUtils.getTempDirectory(), "PostAggregationGapfillQueriesTest"); + private static final String RAW_TABLE_NAME = "parkingData"; + private static final String SEGMENT_NAME = "testSegment"; + + private static final int NUM_LOTS = 4; + + private static final String IS_OCCUPIED_COLUMN = "isOccupied"; + private static final String LEVEL_ID_COLUMN = "levelId"; + private static final String LOT_ID_COLUMN = "lotId"; + private static final String EVENT_TIME_COLUMN = "eventTime"; + private static final Schema SCHEMA = new Schema.SchemaBuilder() + .addSingleValueDimension(IS_OCCUPIED_COLUMN, DataType.INT) + .addSingleValueDimension(LOT_ID_COLUMN, DataType.STRING) + .addSingleValueDimension(LEVEL_ID_COLUMN, DataType.STRING) + .addSingleValueDimension(EVENT_TIME_COLUMN, DataType.LONG) + .setPrimaryKeyColumns(Arrays.asList(LOT_ID_COLUMN, EVENT_TIME_COLUMN)) + .build(); + private static final TableConfig TABLE_CONFIG = new TableConfigBuilder(TableType.OFFLINE).setTableName(RAW_TABLE_NAME) + .build(); + + private IndexSegment _indexSegment; + private List<IndexSegment> _indexSegments; + + @Override + protected String getFilter() { + // NOTE: Use a match all filter to switch between DictionaryBasedAggregationOperator and AggregationOperator + return " WHERE eventTime >= 0"; + } + + @Override + protected IndexSegment getIndexSegment() { + return _indexSegment; + } + + @Override + protected List<IndexSegment> getIndexSegments() { + return _indexSegments; + } + + GenericRow createRow(String time, int levelId, int lotId, boolean isOccupied) { + DateTimeFormatSpec dateTimeFormatter + = new DateTimeFormatSpec("1:MILLISECONDS:SIMPLE_DATE_FORMAT:yyyy-MM-dd HH:mm:ss.SSS"); + GenericRow parkingRow = new GenericRow(); + parkingRow.putValue(EVENT_TIME_COLUMN, dateTimeFormatter.fromFormatToMillis(time)); + parkingRow.putValue(LEVEL_ID_COLUMN, "Level_" + String.valueOf(levelId)); + parkingRow.putValue(LOT_ID_COLUMN, "LotId_" + String.valueOf(lotId)); + parkingRow.putValue(IS_OCCUPIED_COLUMN, isOccupied); + return parkingRow; + } + + @BeforeClass + public void setUp() + throws Exception { + FileUtils.deleteDirectory(INDEX_DIR); + + List<GenericRow> records = new ArrayList<>(NUM_LOTS * 2); + records.add(createRow("2021-11-07 04:11:00.000", 0, 0, true)); + records.add(createRow("2021-11-07 04:21:00.000", 0, 0, true)); + records.add(createRow("2021-11-07 04:31:00.000", 1, 0, true)); + records.add(createRow("2021-11-07 05:17:00.000", 0, 1, true)); + records.add(createRow("2021-11-07 05:37:00.000", 0, 1, true)); + records.add(createRow("2021-11-07 05:47:00.000", 1, 2, true)); + records.add(createRow("2021-11-07 06:25:00.000", 0, 2, true)); + records.add(createRow("2021-11-07 06:35:00.000", 0, 2, true)); + records.add(createRow("2021-11-07 06:36:00.000", 1, 1, true)); + records.add(createRow("2021-11-07 07:44:00.000", 0, 3, true)); + records.add(createRow("2021-11-07 07:46:00.000", 1, 3, true)); + records.add(createRow("2021-11-07 07:54:00.000", 1, 3, true)); + records.add(createRow("2021-11-07 08:44:00.000", 0, 2, false)); + records.add(createRow("2021-11-07 08:44:00.000", 1, 2, false)); + records.add(createRow("2021-11-07 09:31:00.000", 0, 3, false)); + records.add(createRow("2021-11-07 09:31:00.000", 1, 3, false)); + records.add(createRow("2021-11-07 10:17:00.000", 0, 0, false)); + records.add(createRow("2021-11-07 10:33:00.000", 0, 0, false)); + records.add(createRow("2021-11-07 10:33:00.000", 1, 0, false)); + records.add(createRow("2021-11-07 11:54:00.000", 0, 1, false)); + records.add(createRow("2021-11-07 11:57:00.000", 1, 1, false)); + + SegmentGeneratorConfig segmentGeneratorConfig = new SegmentGeneratorConfig(TABLE_CONFIG, SCHEMA); + segmentGeneratorConfig.setTableName(RAW_TABLE_NAME); + segmentGeneratorConfig.setSegmentName(SEGMENT_NAME); + segmentGeneratorConfig.setOutDir(INDEX_DIR.getPath()); + + SegmentIndexCreationDriverImpl driver = new SegmentIndexCreationDriverImpl(); + driver.init(segmentGeneratorConfig, new GenericRowRecordReader(records)); + driver.build(); + + ImmutableSegment immutableSegment = ImmutableSegmentLoader.load(new File(INDEX_DIR, SEGMENT_NAME), ReadMode.mmap); + _indexSegment = immutableSegment; + _indexSegments = Arrays.asList(immutableSegment); + } + + @Test + public void datetimeconvertGapfillTestSelectSelect() { + DateTimeFormatSpec dateTimeFormatter + = new DateTimeFormatSpec("1:MILLISECONDS:SIMPLE_DATE_FORMAT:yyyy-MM-dd HH:mm:ss.SSS"); + DateTimeGranularitySpec dateTimeGranularity = new DateTimeGranularitySpec("1:HOURS"); + long start; + + String gapfillQuery1 = "SELECT " + + "time_col, levelId, lotId, isOccupied, time_col " + + "FROM (" + + " SELECT GapFill(DATETIMECONVERT(eventTime, '1:MILLISECONDS:EPOCH', " + + " '1:MILLISECONDS:SIMPLE_DATE_FORMAT:yyyy-MM-dd HH:mm:ss.SSS', '1:HOURS'), " + + " '1:MILLISECONDS:SIMPLE_DATE_FORMAT:yyyy-MM-dd HH:mm:ss.SSS', " + + " '2021-11-07 4:00:00.000', '2021-11-07 12:00:00.000', '1:HOURS'," + + " FILL(isOccupied, 'FILL_PREVIOUS_VALUE'), TIMESERIESON(levelId, lotId)) AS time_col," + + " isOccupied, lotId, levelId" + + " FROM parkingData " + + " WHERE eventTime >= 1636257600000 AND eventTime <= 1636286400000 " + + " LIMIT 200 " + + ") " Review comment: We should be able to support alias for the subquery. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
