richardstartin commented on issue #8156:
URL: https://github.com/apache/pinot/issues/8156#issuecomment-1031929729


   Hi @rasmus93, thanks for the report. It is unlikely that this is caused by 
3c98a4469644fe94c40ec004c0792870ef9d8af3 if it affects `select count(column) 
from test_table` because the code changed there is only invoked by the `lookup` 
UDF. There are several commits between the two you report:
   
   ```
   commit 86fe41e2e9c17090f1fa9bcc39dbd61e3b649402
   Author: Liang Mingqiang <mili...@linkedin.com>
   Date:   Tue Feb 1 10:50:17 2022 -0800
   
       Timeout if waiting server channel lock takes a long time (#8083)
       
       - make requests be able to time out early when "waiting the channel 
lock".
       - move the request serialization logic out of critical section.
   
   commit 3f761544e2fb6532558c9882f18bfd48e4c927e6
   Author: Richard Startin <rich...@startree.ai>
   Date:   Tue Feb 1 18:48:20 2022 +0000
   
       Upgrade to JsonPath 2.7.0 (#7819)
   
   commit 88dda0e2a09fa035038c8af98aa0ee76ecdff136
   Author: Jialiang Li <j...@linkedin.com>
   Date:   Tue Feb 1 10:29:23 2022 -0800
   
       Validate the numbers of input and output files in 
HadoopSegmentCreationJob (#8098)
       
       Co-authored-by: Jack Li(Analytics Engineering) 
<j...@jlli-mn1.linkedin.biz>
   
   commit 71e28a2313a0e175e64398b195e488b0fd67d49b
   Author: Liang Mingqiang <mili...@linkedin.com>
   Date:   Mon Jan 31 23:53:10 2022 -0800
   
       Wire EmptySegmentPruner to routing config (#8067)
       
       * Remove EmptySegmentPruner from the default path and wire it to the 
config
       
       * fix unit test
       
       * rename isKinesisEnabled as needsEmptySegmentPruner and move to 
TableConfigUtils
       
       * add pinot-kinesis dependency to pinot-segment-local
       
       * hardcode kinesis in TableConfigUtils to avoid pulling pinot-kinesis 
module as dependency
       
       * Minor change on the comments
   
   commit 6eb71f601b0a8fe33147e984e1de5ea93960b9f2
   Author: Richard Startin <rich...@startree.ai>
   Date:   Tue Feb 1 07:25:58 2022 +0000
   
       downgrade verbose log message to DEBUG (#8096)
   
   commit bd42dc38a4b44b03112deefca5498f8bcdde43d9
   Author: Jeff Moszuti <moszu...@users.noreply.github.com>
   Date:   Tue Feb 1 07:00:07 2022 +0000
   
       Support for TIMESTAMP data type in Configuration Recommendation Engin… 
(#8087)
       
       * Support for TIMESTAMP data type in Configuration Recommendation Engine 
(#8086)
       
       * add unit test for TIMESTAMP data type
   
   commit a22cc0022933df6de85b4b966556e95ab5b81c5f
   Author: Prachi Prakash <prachiprakas...@gmail.com>
   Date:   Tue Feb 1 12:28:11 2022 +0530
   
       Broker Side validation for the query with aggregation and col but 
without group by (#7972)
       
       * validate that col expr and aggregate expr is not present without group 
by
       
       * fixing the AggregateMetricsRules test.
       
       * changes as per the review comments
   ```
   
   and I think the most likely culprit is 
86fe41e2e9c17090f1fa9bcc39dbd61e3b649402 which times out queries on the broker 
rather than let them wait indefinitely, especially since you report that this 
happens in a load test. If so, it's not really a regression (this is strictly 
better behaviour) but we should produce better error messages before releasing 
0.10.0. 
   
   Would you be open to building at 3f761544e2fb6532558c9882f18bfd48e4c927e6 
and running your test to help narrow this down? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to