walterddr commented on a change in pull request #8078:
URL: https://github.com/apache/pinot/pull/8078#discussion_r799880648
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java
##########
@@ -102,6 +104,22 @@ public void setRetentionTimeValue(String
retentionTimeValue) {
_retentionTimeValue = retentionTimeValue;
}
+ public String getDeletedSegmentRetentionTimeUnit() {
Review comment:
should we also change the existed
`retentionTimeUnit`/`retentionTimeValue` too? I felt like we should make them
consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
