Jackie-Jiang commented on a change in pull request #8103:
URL: https://github.com/apache/pinot/pull/8103#discussion_r798932879
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1262,14 +1262,12 @@ public void addTable(TableConfig tableConfig)
String tableNameWithType = tableConfig.getTableName();
SegmentsValidationAndRetentionConfig segmentsConfig =
tableConfig.getValidationConfig();
+ if (getTableConfig(tableNameWithType) != null) {
Review comment:
(minor) Suggest moving this as the first step of table creation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
