Jackie-Jiang commented on a change in pull request #8112:
URL: https://github.com/apache/pinot/pull/8112#discussion_r798238643
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java
##########
@@ -105,9 +106,11 @@ public static InstanceAssignmentConfig
getInstanceAssignmentConfig(TableConfig t
int numReplicaGroups = segmentConfig.getReplicationNumber();
ReplicaGroupStrategyConfig replicaGroupStrategyConfig =
segmentConfig.getReplicaGroupStrategyConfig();
Preconditions.checkState(replicaGroupStrategyConfig != null, "Failed to
find the replica-group strategy config");
+ SegmentPartitionConfig segmentPartitionConfig =
tableConfig.getIndexingConfig().getSegmentPartitionConfig();
Review comment:
I think I missed the case of using `ReplicaGroupStrategyConfig` for
non-partitioned table (the config key `numInstancesPerPartition` is confusing).
Will revise the PR accordingly so that it is backward compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
