richardstartin commented on a change in pull request #8100:
URL: https://github.com/apache/pinot/pull/8100#discussion_r797484179
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArithmeticFunctions.java
##########
@@ -54,15 +54,27 @@ public static double mod(double a, double b) {
}
@ScalarFunction
- public static double min(double a, double b) {
+ public static double least(double a, double b) {
return Double.min(a, b);
}
@ScalarFunction
- public static double max(double a, double b) {
+ public static double greatest(double a, double b) {
return Double.max(a, b);
}
+ @Deprecated
Review comment:
min/max were never actually possible to use in SQL because they clashed
with the aggregation function. Ingestion transforms aren't specified in SQL, so
I'm not sure they really need to be SQL compliant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
