suddendust commented on a change in pull request #7959:
URL: https://github.com/apache/pinot/pull/7959#discussion_r796266529



##########
File path: 
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -1459,8 +1460,18 @@ static void updateColumnNames(String rawTableName, 
PinotQuery pinotQuery, boolea
       Map<String, String> columnNameMap) {
     Map<String, String> aliasMap = new HashMap<>();
     if (pinotQuery != null) {
+      Expression selectStarExpr = null;

Review comment:
       Addressed.

##########
File path: 
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -1487,6 +1498,33 @@ static void updateColumnNames(String rawTableName, 
PinotQuery pinotQuery, boolea
     }
   }
 
+  private static void expandStarExpressionsToActualColumns(PinotQuery 
pinotQuery, Map<String, String> columnNameMap,
+      Expression selectStarExpr) {

Review comment:
       Addressed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to