mqliang opened a new issue #8099: URL: https://github.com/apache/pinot/issues/8099
While it's true that any pinot package should has NO dependency on pinot plugins, we have some ***build-in*** plugin, which is likely will never be removed from pinot repo, kinesis is one of the example. Other part of Pinot may need some information about those build-in plugins, https://github.com/apache/pinot/pull/8067 is an example. Is it a good idea to create a "PinotBuiltInPluginsType" file in pinot-common, so that both pinot-kinesis, pinot-broker, pinot-segments-local can import pinot-common and get the `KINESIS_STREAM_TYPE = "kinesis";` string. We currently hardcode the string in https://github.com/apache/pinot/pull/8067 to avoid pulling in dependency, which is not good enough IMO. cc @snleee @Jackie-Jiang @npawar @Jackie-Jiang @sajjad-moradi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
