Jackie-Jiang commented on pull request #8034: URL: https://github.com/apache/pinot/pull/8034#issuecomment-1018857529
> > This shouldn't be required because when the segment is sealed and loaded again as ImmutableSegment, all the entries in the upsert metadata map should have already been replaced. This leak might happen only when user explicitly delete the consuming segment, but that will stall the realtime consumption and also mess up the upsert metadata, so I don't think we need to handle this scenario. > > What about when it's loaded on a different server? It shouldn't be possible as the state transition always go from CONSUMING to ONLINE on the same server. Note that only the consuming segment is `MutableSegment`, the sealed one will become `ImmutableSegment`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
