[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7792: Nicer error message if you have a typo in your schema file

[GitBox]

Jackie-Jiang commented on a change in pull request #7792:
URL: https://github.com/apache/pinot/pull/7792#discussion_r787065512



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -185,9 +185,13 @@ public void setTimeFieldSpec(TimeFieldSpec timeFieldSpec) {
   public void addField(FieldSpec fieldSpec) {
     Preconditions.checkNotNull(fieldSpec);
     String columnName = fieldSpec.getName();
-    Preconditions.checkNotNull(columnName);
+    Preconditions.checkNotNull(columnName,

Review comment:
       (code format) If you apply the [Pinot 
style](https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup#setup-ide),
 it should be formatted as following:
   ```
       Preconditions.checkNotNull(columnName, "Schema spec is missing 
`columnName` property for one of the fields.");
       Preconditions.checkState(!_fieldSpecMap.containsKey(columnName),
           "Field spec already exists for column: " + columnName);
       Preconditions.checkArgument(fieldSpec.getDataType() != null, "'%s' field 
is missing 'dataType' property",
           columnName);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org