richardstartin commented on a change in pull request #8013:
URL: https://github.com/apache/pinot/pull/8013#discussion_r783869937
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/StringUtil.java
##########
@@ -26,7 +26,7 @@
private StringUtil() {
}
- private static final char NULL_CHARACTER = '\0';
+ private static final String NULL_CHARACTER = "\0";
Review comment:
Changing this to a string _looks_ like it would be less efficient, but
it gets to use a very fast intrinsic this way...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
