WyriHaximus commented on a change in pull request #7997:
URL: https://github.com/apache/pinot/pull/7997#discussion_r783701154
##########
File path: kubernetes/helm/pinot/values.yaml
##########
@@ -106,6 +106,13 @@ controller:
port: 9000
annotations: {}
+ ingress:
+ enabled: false
+ annotations: { }
+ tls: []
Review comment:
Should be an object:
```suggestion
tls: {}
```
##########
File path: kubernetes/helm/pinot/values.yaml
##########
@@ -106,6 +106,13 @@ controller:
port: 9000
annotations: {}
+ ingress:
+ enabled: false
+ annotations: { }
Review comment:
```suggestion
annotations: {}
```
##########
File path: kubernetes/helm/pinot/values.yaml
##########
@@ -183,6 +190,13 @@ broker:
# For example, in private GKE cluster, you might add
cloud.google.com/load-balancer-type: Internal
annotations: {}
+ ingress:
+ enabled: false
+ annotations: {}
+ tls: []
Review comment:
Same same
```suggestion
tls: {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
