klsince commented on a change in pull request #7969:
URL: https://github.com/apache/pinot/pull/7969#discussion_r778361089



##########
File path: 
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
##########
@@ -307,6 +306,32 @@ private void reloadSegment(String tableNameWithType, 
SegmentMetadata segmentMeta
     }
   }
 
+  /**
+   * Try to reload a segment without a local index directory. The segment can 
be a consuming
+   * segment from a REALTIME table, or an immutable segment on remote tier 
backend.
+   * @return true if the segment is loaded.
+   */
+  @VisibleForTesting
+  boolean reloadSegmentWithNullIndexDir(String tableNameWithType, String 
segmentName,
+      SegmentDataManager segmentDataManager, @Nullable Schema schema) {
+    IndexSegment segment = segmentDataManager.getSegment();
+    if (segment instanceof ImmutableSegment) {
+      LOGGER.info("Found an immutable segment: {} in table: {} on remote tier 
backend", segmentName,

Review comment:
       👌 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to