klsince commented on pull request #7961: URL: https://github.com/apache/pinot/pull/7961#issuecomment-1004557685
Thanks for the fix, @jadami10! As to the concern of running multiple Server instances on a single machine, the interference may be avoided if each Server instance creates tmp- dir under its own `dataDir`, and this is already done for all tmp- dir created in the pinot/core/data/manager module today. We may extract tmp dir creation and cleanup logic to a util class to manage its naming convention and location in one place, in case later on, folks use tmp. or temp- prefix or put them outside dataDir, making your cleanup logic less effective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
