jackjlli commented on pull request #7961: URL: https://github.com/apache/pinot/pull/7961#issuecomment-1004386471
> > There could be multiple servers running on the same machine (e.g. running integration test that spins up multiple servers). Will the cleanup from the 2nd server wipe out the `tmp-` directory of the 1st server? > > That's a fair point. The integration tests passed which makes me think they're ok. But if someone is actually running it this way in production, this would be bad for them. The directories themselves have no tie to the server, so maybe the only option is to provide a longer threshold. Either delete for than N hours ago or offer a configuration for it? Not a big fan of introducing a config just for cleaning up temp directory but I'm fine with having a fixed threshold just as you mentioned: `delete for more than N hours`. We shouldn't see multiple servers running on the same machine in produciton. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
