npawar commented on pull request #7967: URL: https://github.com/apache/pinot/pull/7967#issuecomment-1002847372
On second thought, this change is tightly coupling the init of registry with pinot-server startup. This is breaking 1. some places such as segment build, which are using the SegmentDirectoryLoaderRegistry agnostic to server startup 2. a whole bunch of tests which are using the registry/building segments and not worrying about registry init. As such I'm thinking of skipping this change, and external SegmentDirectoryLoader registrations can happen via "setSegmentDirectoryLoader" method. Thoughts? cc @klsince since you're touching these methods lately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
