amrishlal commented on a change in pull request #7959: URL: https://github.com/apache/pinot/pull/7959#discussion_r775644230
########## File path: pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/SelectStarWithOtherColsRewriteTest.java ########## @@ -0,0 +1,90 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.broker.requesthandler; + +import com.google.common.collect.ImmutableMap; +import java.util.List; +import java.util.Map; +import org.apache.pinot.common.request.Expression; +import org.apache.pinot.common.request.PinotQuery; +import org.apache.pinot.sql.parsers.CalciteSqlParser; +import org.testng.Assert; +import org.testng.annotations.Test; + + +public class SelectStarWithOtherColsRewriteTest { + + private static final Map<String, String> COL_MAP; + + static { + ImmutableMap.Builder<String, String> builder = ImmutableMap.builder(); + builder.put("homeRuns", "homeRuns"); + builder.put("playerStint", "playerStint"); + builder.put("groundedIntoDoublePlays", "groundedIntoDoublePlays"); + builder.put("playerID", "playerID"); + builder.put("$segmentName", "$segmentName"); + builder.put("$docId", "$docId"); + builder.put("$hostName", "$hostName"); + COL_MAP = builder.build(); + } + + @Test + public void testHappyCase() { + String sql = "SELECT $segmentName,*,$hostName FROM baseballStats"; + PinotQuery pinotQuery = CalciteSqlParser.compileToPinotQuery(sql); + BaseBrokerRequestHandler.updateColumnNames("baseballStats", pinotQuery, false, COL_MAP); + List<Expression> newSelections = pinotQuery.getSelectList(); + Assert.assertEquals(newSelections.get(0).getIdentifier().getName(), "$segmentName"); + Assert.assertEquals(newSelections.get(1).getIdentifier().getName(), "homeRuns"); + Assert.assertEquals(newSelections.get(2).getIdentifier().getName(), "playerStint"); + Assert.assertEquals(newSelections.get(3).getIdentifier().getName(), "groundedIntoDoublePlays"); + Assert.assertEquals(newSelections.get(4).getIdentifier().getName(), "playerID"); + Assert.assertEquals(newSelections.get(5).getIdentifier().getName(), "$hostName"); + } + + @Test + public void testDupCols() { + String sql = "SELECT playerID,homeRuns,* FROM baseballStats"; + PinotQuery pinotQuery = CalciteSqlParser.compileToPinotQuery(sql); + BaseBrokerRequestHandler.updateColumnNames("baseballStats", pinotQuery, false, COL_MAP); + List<Expression> newSelections = pinotQuery.getSelectList(); Review comment: This is what I am seeing on mysql (no dedup when * is combined with column names in select list), but not sure how standards complaint mysql is. In either case we should check against at least two other databases before setting behavior here since it will be difficult to change once set. ``` mysql> select *, cases, abs(cases) from covid_cases; +------------+-------+-------+------------+ | date | cases | cases | abs(cases) | +------------+-------+-------+------------+ | 2021-01-01 | 30 | 30 | 30 | | 2021-01-02 | 60 | 60 | 60 | | 2021-01-03 | 120 | 120 | 120 | | 2021-01-04 | 100 | 100 | 100 | | 2021-01-05 | 80 | 80 | 80 | | 2021-01-06 | 70 | 70 | 70 | | 2021-01-07 | 85 | 85 | 85 | | 2021-01-08 | 65 | 65 | 65 | | 2021-01-01 | 70 | 70 | 70 | | 2021-01-02 | 100 | 100 | 100 | +------------+-------+-------+------------+ 10 rows in set (0.00 sec) mysql> select * from covid_cases; +------------+-------+ | date | cases | +------------+-------+ | 2021-01-01 | 30 | | 2021-01-02 | 60 | | 2021-01-03 | 120 | | 2021-01-04 | 100 | | 2021-01-05 | 80 | | 2021-01-06 | 70 | | 2021-01-07 | 85 | | 2021-01-08 | 65 | | 2021-01-01 | 70 | | 2021-01-02 | 100 | +------------+-------+ 10 rows in set (0.00 sec) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
