npawar commented on a change in pull request #7921:
URL: https://github.com/apache/pinot/pull/7921#discussion_r773450105
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java
##########
@@ -508,22 +516,28 @@ public String checkTableConfig(String tableConfigStr) {
+ "Validate given table config and schema. If specified schema is
null, attempt to retrieve schema using the "
+ "table name. This API returns the table config that matches the
one you get from 'GET /tables/{tableName}'."
+ " This allows us to validate table config before apply.")
- public String validateTableAndSchema(TableAndSchemaConfig tableSchemaConfig)
{
+ public String validateTableAndSchema(
+ TableAndSchemaConfig tableSchemaConfig,
+ @ApiParam(value = "comma separated list of validation skip")
@QueryParam("typesToSkip") String typesToSkip) {
TableConfig tableConfig = tableSchemaConfig.getTableConfig();
Schema schema = tableSchemaConfig.getSchema();
if (schema == null) {
schema = _pinotHelixResourceManager.getSchemaForTableConfig(tableConfig);
}
- return validateConfig(tableSchemaConfig.getTableConfig(), schema);
+ return validateConfig(tableSchemaConfig.getTableConfig(), typesToSkip,
schema);
+ }
+
+ private List<TableConfigUtils.ValidationType> toSkippedTypes(String
typesToSkip) {
+ return typesToSkip == null ? Collections.emptyList() :
java.util.Arrays.stream(typesToSkip.split(","))
Review comment:
move this to TableConfigUtils since you're using it in both classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
