jerrinot opened a new pull request #7928: URL: https://github.com/apache/pinot/pull/7928
## Description 4 small improvements in container image builds. See commits message. The most important improvement is to allow overriding Dockerfile JDK_VERSION from `docker-build.sh` That's actually a bug fix, because without this change the `docker-build.sh` fails to produce a container image. Why? The script set `JAVA_VERSION` to 8. This makes Docker build to pick `openjdk:8` as a base image. But `Dockefile` has `JDK_VERSION` hard-coded as 11. This is passed as a system property to Maven build and Maven actives the `other-jdk-maven-compiler-plugin` profile. This profile assumes JDK9+, it tries to set `-release` flag when invoking javac. This fails the build process, because JDK8 does not support the the flag. Other improvements are rather cosmetic. Perhaps the shallow clone is worth mentioning. I assume git history is not needed during the build, otherwise the shallow build could cause troubles. ## Documentation Interestingly enough `readme.md` described the JDK_VERSION parameter, even the docker-build.sh did not support it (before this changeset). I removed the `OpenJDK Image` parameter, which is still not supported by the script. The readme is talking about special measures when building on M1 MacBook. This looks outdated too. The official OpenJDK container images do support arm64 architecture so I assume it should just work. So perhaps that part of readme should be updated too. Caveat: I have no M1 machine to validate this assumption. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
