richardstartin commented on a change in pull request #7927:
URL: https://github.com/apache/pinot/pull/7927#discussion_r771821814
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -543,14 +552,14 @@ private void processStreamEvents(MessageBatch
messagesAndOffsets, long idlePipeS
_currentOffset =
messagesAndOffsets.getNextStreamParitionMsgOffsetAtIndex(index);
_numRowsIndexed = _realtimeSegment.getNumDocsIndexed();
- _numRowsConsumed++;
streamMessageCount++;
+ NUM_ROWS_CONSUMED_UPDATER.incrementAndGet(this);
}
updateCurrentDocumentCountMetrics();
if (streamMessageCount != 0) {
_segmentLogger.debug("Indexed {} messages ({} messages read from stream)
current offset {}", indexedMessageCount,
streamMessageCount, _currentOffset);
- } else {
+ } else if (messagesAndOffsets.getUnfilteredMessageCount() == 0) {
Review comment:
Prevents unnecessary latency when there has been a bad batch, there is
probably data waiting to be consumed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
