npawar commented on a change in pull request #7921:
URL: https://github.com/apache/pinot/pull/7921#discussion_r771549152
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
##########
@@ -330,8 +333,8 @@ static void validateTaskConfigs(TableConfig tableConfig,
Schema schema) {
// TODO task specific validate logic should directly call to
PinotTaskGenerator API
if (taskTypeConfigName.equals(REALTIME_TO_OFFLINE_TASK_TYPE)) {
// check table is not upsert
- Preconditions.checkState(tableConfig.getUpsertMode() ==
UpsertConfig.Mode.NONE,
- "RealtimeToOfflineTask doesn't support upsert ingestion mode!");
+ Preconditions.checkState(tableConfig.getUpsertMode() ==
UpsertConfig.Mode.NONE || taskTypeConfig.containsKey(
Review comment:
my thought was that we should provide it as an API param. We might
extend this in future to skip all sorts of validations, which will not be
limited to things in taskConfigs.
Previously from @Jackie-Jiang as well
```
To workaround the cases where user knows it doesn't work but still want to
bypass the validation, we can add some skip validation rules as an additional
parameter when updating table config/schema.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
