jackjlli commented on a change in pull request #7878:
URL: https://github.com/apache/pinot/pull/7878#discussion_r766258801
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
##########
@@ -163,17 +163,21 @@
@GET
@Produces(MediaType.APPLICATION_JSON)
@Path("/segments/{tableName}")
- @ApiOperation(value = "List all segments", notes = "List all segments")
+ @ApiOperation(value = "List all segments. The 'liveOnly' parameter is used
to get the list of segments"
Review comment:
Discussed it offline. The existing listSegments returns all the segments
regardless of their states. Thus, the optional parameter should be called sth
like `excludeReplacedSegments` to indicate that replaced segments are filtered
out in the response payload. Later on, we can add more and more parameters like
`excludeErrorSegments`, `excludeConsumingSegments` to filter more segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
